This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Don't require alias in public room list. #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rooms now no longer require an alias to be published. Also, changes the way we pull out state of each room to not require fetching all state events.
|
|
||
| name_event = state.get((EventTypes.Name, ""), None) | ||
| name_event = yield get_state(EventTypes.Name, "") |
There was a problem hiding this comment.
I guess this is so we don't have to pull in the entire room state for each room? Might be worth adding a comment explaining why we've pick this particular performance trade off.
|
retest this please |
|
@NegativeMjark PTAL I'm afraid I added some SQL and a check for JoinRules = Public |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rooms now no longer require an alias to be published.
Also, changes the way we pull out state of each room to not require fetching all state events.